Skip to content

Add test/values/trap-in-post-return.wast #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

Conversation

lukewagner
Copy link
Member

This PR adds a .wast calling all the canon function that contain a may_leave trap from under a post-return function testing that they trap.

Copy link
Collaborator

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big file! Thanks for adding it.

Alex and I are deep in the process of upstreaming wasip3-prototyping into the main wasmtime repo, so I might not have a chance to get this test passing this week, but it's on my to-do list.

@dicej
Copy link
Collaborator

dicej commented Jun 27, 2025

FYI, I've got the test passing in this branch, but I'm going to hold off PRing that until we're done upstreaming async support to Wasmtime. We'll probably add a config option to get the old behavior (i.e. allowing import calls in post-return functions) in case this breaks real-world pre-async code.

@lukewagner
Copy link
Member Author

Awesome, thanks!

@lukewagner lukewagner merged commit 35c6d24 into main Jun 27, 2025
2 checks passed
@lukewagner lukewagner deleted the post-return-trap branch June 27, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants