Skip to content

chore: rename revoke_buffer to reclaim_buffer #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vados-cosmonic
Copy link
Collaborator

This commit renames revoke_buffer which is used during stream copying to reclaim_buffer which hopefully better conveys (if only slightly) the handoff/change in ownership of the buffer in use.

@lukewagner
Copy link
Member

Thanks! Could you also update the RevokeBuffer function type to match?

@vados-cosmonic vados-cosmonic force-pushed the chore=rename-revoke-buffer branch from 4485629 to 097e8df Compare June 26, 2025 18:24
This commit renames `revoke_buffer` which is used during stream
copying to `reclaim_buffer` which hopefully better conveys (if only
slightly) the handoff/change in ownership of the buffer in use.

Signed-off-by: Victor Adossi <[email protected]>
@vados-cosmonic vados-cosmonic force-pushed the chore=rename-revoke-buffer branch from 097e8df to fde7802 Compare June 26, 2025 18:24
@vados-cosmonic
Copy link
Collaborator Author

Ah thanks @lukewagner -- done!

@lukewagner
Copy link
Member

Thanks again!

@lukewagner lukewagner merged commit 7490960 into WebAssembly:main Jun 26, 2025
1 check passed
@vados-cosmonic vados-cosmonic deleted the chore=rename-revoke-buffer branch June 26, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants