Tidy CABI Python code #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vados-cosmonic
approved these changes
Jun 26, 2025
| @@ -1281,40 +1279,52 @@ class ReadableStream: | |||
| read: Callable[[ComponentInstance, WritableBuffer, OnCopy, OnCopyDone], None] | |||
| cancel: Callable[[], None] | |||
| drop: Callable[[], None] | |||
|
|
|||
| class WritableStream: | |||
There was a problem hiding this comment.
How strict do we want to be about this class being abstract? Not sure if we want to pull in the usual Python ABC machinery here or just add a note.
Also fine leaving this as is since this is just python flavored pseudo code :)
There was a problem hiding this comment.
Heh, yeah, I looked into ABC a bit, and maybe I didn't find the Zen of that feature, but I thought it was less clear -- mostly I just want a thing that lets me write names and types without function bodies. Since this is just Python-flavored pseudo-code, I stopped there, but if you have any good ideas that are clear and succinct, feel free to suggest (in a separate PR).
Co-authored-by: Victor Adossi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hopefully addresses the confusion surfaced in #537. (No behavior change)