Merge reference types repo #120
Conversation
I missed this in #988.
The full error message generated by the interpreter is "unreachable executed", but all of the other tests check for just "unreachable".
* Add missing eq_ref * Fix export index computation * Remove bogus test
The start function is invoked after the store has been modified. So if a start function traps, all data and element segments will have been copied into the memory and table respectively. This means that functions can be invoked on this instance, even though the instance is not available to the embedder directly.
use `local.get` name instead of `get_local` which isn't used elsewhere.
…Assembly#75) * Rename elem/data.drop * Reorder bulk instructions * Rename interpreter AST ref constructors to match reftype repo * Update interpreter README
… op proposal (WebAssembly#35) Adds table.size, table.grow, table.fill to overview, spec, interpreter, and tests, as decided at recent CG meeting. Also adds a few more tests for table.get and table.set. Also, change interpreter's segment encoding to match bulk ops proposal, addressing WebAssembly#18. (Not updated in spec yet, since corresponding spec text is still missing from bulk ops proposal.)
The data count section has a count that must match the number of data segments. If the data count section isn't present, then `memory.init` and `data.drop` cannot be used. Fixes issue WebAssembly#73.
* Add definition of free index sets * Simplify datacount side condition * Explain convention about multiple occurrences of meta variables
Issue WebAssembly/reference-types#69 requires that `ref.null` instructions include a reference type immediate. This concept isn't present in the bulk-memory proposal, but the encoding is (in element segment expressions). This change updates the binary and text format, but not the syntax. This is OK for now, since the only reference type allowed here is `funcref`.
The original commit to add a bottom type removed this test as it would now unexpectedly validate. Now that a bottom type is removed it would be good to keep it.
In the generated test files the generic imports contained a function that does not exist anymore. This caused all tests to fail. This PR removes the function from the imports.
* [js-api] Link to the fork for the core specification. * [js-api] More subtyping removal. * [js-api] Fix bugs in Table constructor. * Add an assertion to ToWebAssemblyValue.
|
When merging, which button should I use, between "Create a merge commit" and "Rebase and merge"? (Certainly not "Squash and merge" this time :) ) "Create a merge commit" is currently disabled for this repo, but I can enable it if necessary. |
|
@aheejin You'll want "Create a merge commit". I typically merge manually from the command-line so I don't have to enable the option (since we normally don't want it). |
|
@binji Thanks! By the way, this proposal also depends on multi-value. How should I maintain the merges between the two upstream repos? Just do merges from both repos and resolve conflicts? |
|
@ioannad I didn't mean there was a problem with #112, but you said there were lots of conflicts (because we didn't revert all squashed commits, I presume?), I thought it would be cleaner to revert all squashed commits (which I did in #115, #116, #117, and #119) and merge upstream from the fresh state. |
|
@Ms2ger Uh, sorry, you merged this using the command line..? This repo does not enable that option (unless you do that using the command line), so I'm wondering.... |
|
Yeah, it would be a little silly to do all this work to create an actual merge commit and then squash it in the UI :) |
This merges reference types repo. The only thing manually fixed was
resolving conflict in README.md.
cc @ioannad