[bikeshed] Fix Bikeshed patch-up script and add debugging aids #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossberg
changed the title
tlively
approved these changes
Jun 20, 2025
Co-authored-by: Thomas Lively <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1924.
Bikeshed substitution steam-rolls over Latex content, which this script was supposed to fix up. But some of the cases either were outdated by changes to Sphinx/Katex/Bikeshed or never worked.
This patch now makes the script fail on warnings and adds suitable diagnostics, especially useful for CI. Unfortunately, I still can't get Bikeshed to run on my local machine.