wasm2c: Mmap+guard on big-endian won't move memory (fix #2599) #2602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shravanrn
force-pushed
the
w2c-s390x
branch
5 times, most recently
from
3ee91d7 to
e1c6a86
Compare
|
Sorry, it took a few iterations to get all the tests passing. Looks like things are working now. |
sbc100
reviewed
Jun 3, 2025
| const uint64_t mmap_size = | ||
| get_alloc_size_for_mmap_default32(memory->max_pages); | ||
| void* addr = os_mmap(mmap_size); | ||
| unsigned char* addr = os_mmap(mmap_size); |
There was a problem hiding this comment.
Why not use MEMORY_CELL_TYPE here and avoid the cast below?
| @@ -492,6 +496,8 @@ typedef struct { | |||
| * volatile. | |||
| */ | |||
| _Atomic volatile uint8_t* data; | |||
| /** The location after the the reserved space for the linear memory data. */ | |||
There was a problem hiding this comment.
Might be worth clarifying if is the address after the last byte of memory, or if it can also include padding/page alignment. From the usage it looks like former?
| } | ||
| #endif | ||
|
|
||
| memory->data = calloc(byte_length, 1); |
There was a problem hiding this comment.
Why is an explicit cast to MEMORY_CELL_TYPE need above but not here?
| @@ -771,7 +771,7 @@ wasm_rt_func_type_t wasm2c_fac_get_func_type(uint32_t param_count, uint32_t resu | |||
|
|
|||
| if (param_count == 1 && result_count == 1) { | |||
| va_start(args, result_count); | |||
| if (true && va_arg(args, wasm_rt_type_t) == WASM_RT_I32 && va_arg(args, wasm_rt_type_t) == WASM_RT_I32) { | |||
| if (true && va_arg(args, int) == WASM_RT_I32 && va_arg(args, int) == WASM_RT_I32) { | |||
There was a problem hiding this comment.
Are these change from a different PR? If so, can they be landed separately to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.