This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Change wasi:clocks from include to import in wasi:http/proxy
#115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
wasi:clocksincludestatement to individualimportstatements inwasi:http/proxy. This came out of a conversation with @sunfishcode yesterday, who pointed out that if we're going to add timezones towasi:clocks(WebAssembly/wasi-clocks#61),wasi:http/proxymay not actually want to provide timezone support.By switching from a catch-all
includeto individualimportstatements, we can decide later whether this is something we'd like to include. But conservatively we can start with the assumption that we won't.This has some precedent in how we're handling our re-exports of
wasi:cli:wasi:http/proxyincludeswasi:cli/stdinandwasi:cli/stdout- but it does for example not include support for files or sockets.