Skip to content

Specify the casing of field keys and values. #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2024
Merged

Specify the casing of field keys and values. #121

merged 1 commit into from
Jul 31, 2024

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jul 16, 2024

Closes #117

lukewagner
lukewagner approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@lukewagner lukewagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rylev
Copy link
Contributor Author

rylev commented Jul 31, 2024

@lukewagner I don't have access to merge this. Is there anything else that needs to be done to merge this PR?

@pchickey
Copy link
Contributor

I'm going to take the liberty to merge while Luke is away on vacation.

@pchickey pchickey merged commit 4733a63 into WebAssembly:main Jul 31, 2024
1 check passed
@rylev rylev deleted the specify-field-casing branch July 31, 2024 15:57
@yoshuawuyts yoshuawuyts mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukewagner lukewagner lukewagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perhaps be more specific about casing of field-keys
3 participants
@rylev @pchickey @lukewagner