Add note to the Migrate checkbox to indicate leaving it unchecked will duplicate #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not completely against this in this location, but I feel like we need to word it in a way that says that this could be considered a feature, if wanting to create many similar ones relatively quickly. As is, it still comes off as "oh no! warning!" for lack of better phrasing. Also let's PR it against the release170 branch instead of master. |
|
Thanks Michael I'll think on the verbiage and update the patch. Let me know if you have any thoughts am happy for your wording here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a little exposure to the duplicate functionality available.
Fixes #760