Skip to content

feat: configure keystore parameters with environment variables #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lenkan
Copy link
Contributor

@lenkan lenkan commented May 2, 2025

This PR enables you to configure which keystore to access using environment variables.

Summary of changes:

  • Extracted --name, --base and --passcode into a common "Parsery.keystore()" method. Not sure about the module or naming here, tried to follow https://github.com/WebOfTrust/keripy/blob/main/ref/naming.md, but please advise. Should be easy search replace to modify.
  • Removed redundant "transferable=True" default option which seemed to have been left over from copy-paste. Please advise if not correct and I can change back.
  • Inlined the "addInceptingArgs" as it was only used in one place. I thought we could define one pattern for common arguments and use that everywhere.

Closes #955

@lenkan lenkan force-pushed the fix-keystore-args branch from 3f43d13 to 41d7615 Compare May 2, 2025 13:36
@lenkan lenkan marked this pull request as ready for review May 2, 2025 13:55
@lenkan lenkan force-pushed the fix-keystore-args branch from 6aec942 to 3e570b3 Compare May 2, 2025 14:03
@lenkan
Copy link
Contributor Author

lenkan commented May 2, 2025

I believe the failed windows tests are fixed by #986

@lenkan lenkan force-pushed the fix-keystore-args branch from 3e570b3 to 4ff4842 Compare May 6, 2025 10:55
@m00sey m00sey requested review from pfeairheller and m00sey May 6, 2025 14:13
@lenkan lenkan force-pushed the fix-keystore-args branch from 4ff4842 to 8a2b920 Compare May 9, 2025 12:07
@lenkan
Copy link
Contributor Author

lenkan commented May 20, 2025

Note that if you are hesitant about the environment variables being enables, we can disable it. It is trivial to add now when the keystore parameters are extracted to its own module. We can also hide it being a feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: ability to specify keystore parameters as environment variables
1 participant