Automated Importation of claims into LinkedTrust DB #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvelez17
reviewed
Dec 10, 2024
| ); | ||
|
|
||
| -- Create Edge table | ||
| CREATE TABLE IF NOT EXISTS "Edge" ( |
Contributor
There was a problem hiding this comment.
always separate out migrations into a separate pr
Contributor
There was a problem hiding this comment.
tho this doesn't actually look like a migration is it for manual testing locally?
Contributor
|
hey @Emos21 this is interesting and ambitious, i think we want to break it apart into specific functional parts, maybe later we can walk thru after Dec 20 in person |
gvelez17
reviewed
Dec 25, 2024
| col_names = [desc[0] for desc in cur.description] | ||
| return dict(zip(col_names, result)) | ||
| else: | ||
| with get_conn() as conn: |
Contributor
There was a problem hiding this comment.
please make linter changes separately and actual changes in a smaller pr
too hard to review large pr with many lint-only changes and some real ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.