Skip to content

use client side proof if provided #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvelez17 merged 1 commit into from
Aug 15, 2025
Merged

use client side proof if provided #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions src/api/claims.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ export async function createClaim(req: AuthRequest, res: Response): Promise<Resp
stars,
score,
amt,
unit
unit,
proof: clientProof,
issuerId: clientIssuerId,
issuerIdType: clientIssuerIdType
} = req.body;

const userId = req.user?.id || req.body.issuerId;
Expand Down Expand Up @@ -56,18 +59,29 @@ export async function createClaim(req: AuthRequest, res: Response): Promise<Resp
score,
amt,
unit,
issuerId: userId,
issuerIdType: 'URL' as const,
issuerId: clientIssuerId || userId,
issuerIdType: (clientIssuerIdType || 'URL') as const,
effectiveDate: new Date()
};

// Try to sign the claim with server key, but don't fail if it doesn't work
let proof = null;
try {
proof = await signClaimWithServerKey(claimData, authMethod);
} catch (error) {
console.error('Warning: Failed to sign claim with server key:', error);
// Continue without proof - claim creation should not fail
// Use client-provided proof if available, otherwise try server signing
let proof = clientProof || null;

if (!proof) {
// Only try server signing if no client proof was provided
try {
proof = await signClaimWithServerKey(claimData, authMethod);
console.log('Claim signed by server for user:', userId);
} catch (error) {
console.error('Warning: Failed to sign claim with server key:', error);
// Continue without proof - claim creation should not fail
}
} else {
console.log('Using client-provided proof from:', clientIssuerId);
// Store the proof as a JSON string if it's an object
if (typeof proof === 'object') {
proof = JSON.stringify(proof);
}
}

// Create claim with proof
Expand Down