Solve image issue #250
Merged
Solve image issue #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvelez17
reviewed
Aug 17, 2025
| }); | ||
|
|
||
| // Enum validation | ||
| if (body.howKnown && !['FIRST_HAND', 'SECOND_HAND', 'WEB_DOCUMENT', 'VERIFIED_LOGIN', 'BLOCKCHAIN', 'SIGNED_DOCUMENT', 'PHYSICAL_DOCUMENT', 'INTEGRATION', 'RESEARCH', 'OPINION', 'OTHER'].includes(body.howKnown)) { |
Collaborator
There was a problem hiding this comment.
this should pull from the enum - otherwise we can get out of sync. Can you fix this in a follow on please?
gvelez17
reviewed
Aug 17, 2025
| field: 'howKnown', | ||
| issue: 'invalid_enum_value', | ||
| received: body.howKnown, | ||
| expected: ['FIRST_HAND', 'SECOND_HAND', 'WEB_DOCUMENT', 'VERIFIED_LOGIN', 'BLOCKCHAIN', 'SIGNED_DOCUMENT', 'PHYSICAL_DOCUMENT', 'INTEGRATION', 'RESEARCH', 'OPINION', 'OTHER'] |
Collaborator
There was a problem hiding this comment.
again, we want list of values in exactly ONE place in the code, import in all other places
gvelez17
reviewed
Aug 17, 2025
| }); | ||
| } | ||
|
|
||
| if (body.issuerIdType && !['DID', 'ETH', 'PUBKEY', 'URL'].includes(body.issuerIdType)) { |
Collaborator
There was a problem hiding this comment.
same here - please no string arrays, this should be pulled from one place
gvelez17
approved these changes
Aug 17, 2025
Collaborator
gvelez17
left a comment
gvelez17
left a comment
There was a problem hiding this comment.
Lets ship it, please follow on to address comments, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief summary of the changes in this PR.
Type of Change
Checklist
4- steps to test ?
Please provide a brief summary of the steps required to test the changes in this PR.
5- results ?
Please provide a brief summary of the results after testing the changes in this PR.
7- screenshots ?
Please provide screenshots of the results after testing the changes in this PR.