Skip to content

Commit

Permalink
Restore "Analyze Stacktrace" functionality
Browse files Browse the repository at this point in the history
Summary:
# Context

The "Analyze Stacktrace" functionality was broken for a long time. A user attempted to use it and reported it was not able to extract a stacktrace.

# Solution

This diff restore the basic functionality by:

* Refactoring some private code so it's testable
* Adding a unit test for the stacktrace extraction
* Updating the regex that was used to identify stacktraces in the terminal
* Adding an E2E tests
* Making the opening mechanism more solid

Despite of this, the functionality is quite fragile. I am considering if we should drop it altogether, instead.

Reviewed By: alanz

Differential Revision: D69518411

fbshipit-source-id: d6270e1e41ae357f6cea4f18f277b35d255bf2d6
  • Loading branch information
robertoaloi authored and facebook-github-bot committed Feb 12, 2025
1 parent 9189988 commit 8d0c680
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions test_projects/end_to_end/fixtures/erlang-stacktrace.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
THIS FILE CONTAINS AN ARTIFICIAL ERLANG STACKTRACE
Details: exception error: made up error
in function local_g/0 (definitions/src/local_def.erl, line 7)
in call from local_def:f/0 (definitions/src/local_def.erl, line 5)

0 comments on commit 8d0c680

Please sign in to comment.