ssr: properly match Pat::Literal

Summary: As title Reviewed By: TD5 Differential Revision: D69455464 fbshipit-source-id: f424da4b57d1822464e6eee8421e2d1e444901e5
WhatsApp · Feb 11, 2025 · eaac6b5 · eaac6b5
1 parent 863d44a
commit eaac6b5
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/crates/ide_ssr/src/matching.rs b/crates/ide_ssr/src/matching.rs
@@ -631,6 +631,22 @@ impl<'a> Matcher<'a> {
                     );
                 }
             }
+            (
+                SubIdRef::AnyExprRef(AnyExprRef::Pat(Pat::Literal(pat_lit))),
+                SubIdRef::AnyExprRef(AnyExprRef::Pat(Pat::Literal(code_lit))),
+            ) => {
+                let pat_lit_str = render_str(self.sema, pat_lit);
+                let code_lit_str = render_str(self.sema, code_lit);
+                if pat_lit_str == code_lit_str {
+                    return Ok(());
+                } else {
+                    fail_match!(
+                        "Pattern had `{}`, code had `{}`",
+                        &pat_lit_str,
+                        &code_lit_str
+                    );
+                }
+            }
             (
                 SubIdRef::AnyExprRef(AnyExprRef::Expr(Expr::Var(code_var))),
                 SubIdRef::AnyExprRef(AnyExprRef::Expr(Expr::Var(pat_var))),

diff --git a/crates/ide_ssr/src/tests.rs b/crates/ide_ssr/src/tests.rs
@@ -713,6 +713,16 @@ fn ssr_expr_case() {
     );
 }
 
+#[test]
+fn ssr_underscore_pattern_in_code_and_placeholder_in_ssr_do_not_match_if_atom_literal_pattens_do_no_match()
+ {
+    assert_matches(
+        "ssr: case X of false -> _@BranchA; _@PatA -> _@BranchB end.",
+        "foo(X) -> case X of true -> a; _ -> b end.",
+        &[],
+    );
+}
+
 #[test]
 fn ssr_expr_receive() {
     assert_matches(