Rel1 39 #30
Closed
Rel1 39 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change uses the core change 233677a9a54a4bd50a92ed226c5e0e49b23744fc included in MediaWiki 1.39 if available. Change-Id: I155fe89da56f533f2dd68c8c5d70433fe8429629
Change-Id: Iaf20a4847bf315c7d7d43943a1c505cb1f5f3a68
Change-Id: I51b9f1b289397b97e1046f1a5061a714275e4fdd
Change-Id: I3d60f2045e05bdeec3868f746ebc86977134f5e6
Change-Id: If94c73a4f2ee161d7dfb7128155240150f2e3c76
Change-Id: I1e4dc57cb4d44e4b60347b5dedec6429ff4b3bf0
Change-Id: I9884b3f6e370644369cec1b6fdc5de180f95382d
Change-Id: Ibdfd55e830614f5ed53fd5def7d04bc2aaf36fac
Change-Id: Ib94da01151e73c8e10955a8b02f4803bf558abb5
Change-Id: Ie8d2deb8e0d69b1f176fd38be37b649f89e8866b
Change-Id: Id573c83ae23f026960930bda264ef4dfb0090a8d
Change-Id: Id86e71d77571f661e067c038b11f72631180788c
Change-Id: I1521667505026d65803ea7280cbbe6278699ae76
Change-Id: I34948a84b425903860a4d63598e0d58b70d8bbdf
Change-Id: I183ce61215f6c7cc6e53e40812aafd4eeabc4aca
Change-Id: I850d55d1c48649b9b11569c918972fd4846dcb8e
Change-Id: I849f3e1f8b5cfb7d0f832faf2a35824c9c46db4c
Change-Id: I9dc4906942ffafca087ffcb3f3f8f0673bd35452
…ldown Change-Id: I1bf688ad7ff4836e017b858a1dc12d869edf130e
Change-Id: I4f6d80d5a4810560ac6b1bcd241507d529639b85
Change-Id: If51c773e74085c7245879f553bf9bf578a329ced
Being able to see the number of rows easily is really useful when a table is close to the max number of columns, this small change to the display enables that at a glance without needing to count by hand. Change-Id: Ib50c43083371af1d694aa28414983ead72168ccf
The "tl_namespace" and "tl_title" fields were removed, replaced by the "tl_target_id" field (which was added in MW 1.38). So we might as well use this new field already with MW 1.38. Change-Id: Ic2acbe7d5aee2bc891c93d9425f4d0a38bf92336
In some PHP installations, treating them as a string causes problems - cast them to string to avoid this. Change-Id: I2e5fed092ad172f7640dfce2132bb8f67e67b875
Non-null name seems to be required for MW 1.39+ Change-Id: I976ad6e68128e1e76a263193833fb11370f9198a
Change-Id: I25978a18f913a851556bf1c9cd4fda3dcdd42720
Prepare for newer version of stylelint-config-wikimedia Bug: T279431 Change-Id: Ie49964a90bdc9418ecbb3b81082ffc52d7be1743
Change-Id: I436c532f258e8b7edfe1f7ae4cb1f5713155b944
For at least some configurations/version of PHP 8, round() can no longer be called on a string. So, we call round( floatval() ) on the value instead. Also remove the is_int() checks, since the value will presumably never be an integer per se - it is a string. Change-Id: I23b4512d21b97d573b1ef3737333cccff71670cc
Now that we may use MW's LB abstractions for managing Cargo DB connections on some cases, we must account for the fact that these tend to return DBConnRef instances instead of raw connection handles. Unwrap DBConnRefs accordingly so that we can operate on the backing connection directly when setting the charset.
Change-Id: I628886a39b2a0c540761cbf228ee2fdfad8de2e6
…ubject) of type array|string is deprecated" Change-Id: I0781b40459109b0e16af90f87bb83a797777c29c
Bug: T358843 Change-Id: I8c0daa6f07bc15b5fcf3fdb28f39a7fd86a16402
Null check the query, since it may be absent. Bug: T356568 Change-Id: I1d24365c6c3492d8b9b7e9be2d37295199bc53c9
Bug: T341408 Change-Id: Iccde6f6137f389b01db28f78acb4f92ee129cd61
Cargo has been double-escaping query results since 2e587ba. On PHP 8.2, this is causing single quotes in benign outputs such as "Cox's Bazaar" to be double-escaped, as htmlspecialchars() on PHP 8.1 and newer escapes single quotes by default. The double-escaping can and should be investigated and fixed upstream, but to unblock our PHP 8.2 migration, simply switch back the htmlspecialchars() behavior to the original so that the single quotes do not get double-escaped.
PLATFORM-9297 | Don't double-escape single quotes in Cargo results
Change-Id: I13116a9cd3f80f773fe5a8984b4870af01f15e25
Change-Id: I8323c4900f24078c2f55b7c54a489efc66ec31c9
Change-Id: I28379f0975bdfc7ad9d7df9c7391bdf60ae721ac
Change-Id: I287ed519fe95083c4ad60eba1eeae6ce2274238e
Change-Id: I73de717699cfa970bd4be6e27b3e7dc3a07dfdeb
Follow-Up: I6897388ef05b5f1d61f09caaa9c328cdbe84f431 Change-Id: Ic8a2c4bf473d3e1c54e1bc4729ed13086ab15f26
Change-Id: I03fbc0e54da8fdb1a5706036b27d43a2834759ef
Cargo security fixes from upstream
Change-Id: I28379f0975bdfc7ad9d7df9c7391bdf60ae721ac
Change-Id: I73de717699cfa970bd4be6e27b3e7dc3a07dfdeb
Change-Id: Ic0465065347598983b80d10ef339ceac579dd9d8
Change-Id: I287ed519fe95083c4ad60eba1eeae6ce2274238e
Patch by BlankEclair. Change-Id: I15d05996ff1eaf203cf726b02925687e671ba272
UGC-6024 | Security patches - Cargo (cherry-picks)
mmeller-wikia
commented
Feb 12, 2025
mmeller-wikia
commented
Feb 12, 2025
mmeller-wikia
commented
Feb 12, 2025
| // Bypass this particular check, for Special:Drilldown and possibly | ||
| // other query locations. | ||
| if ( !$allowFieldEscaping ) { | ||
| $regexps['/`/'] = '`'; |
mmeller-wikia
commented
Feb 13, 2025
Comment on lines
+180
to
181
| // FIXME: This method doesn't exist! | ||
| $nextWeekDate = self::getJulianDayTimeValue( $nextWeekJD ); |
mmeller-wikia
commented
Feb 13, 2025
Comment on lines
+198
to
+199
| $sqlQuery->mWhereStr = CargoServices::getCargoConnectionProvider()->getConnection( DB_REPLICA ) | ||
| ->addIdentifierQuotes( '_pageID' ) . " = " . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.