Add support of UnionType in OpenAPI schema #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofr
reviewed
Feb 8, 2025
| if hasattr(types, 'UnionType') and isinstance(hint_class, types.UnionType): | ||
| # Extract the arguments of the union (e.g., `str | int` -> (str, int)) | ||
| args = get_args(hint_class) | ||
| # Convert to the old `typing.Union` style |
There was a problem hiding this comment.
To simplify future life, usually it's better to rely on newer style, not vice-versa.
|
The support of new types will be implemented in future pull request |
mofr
approved these changes
Feb 10, 2025
mofr
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for writing union types as X | Y for OpenAPI generator
It was added in Python 3.10 as part of PEP 604