Use redis as a storage for throttling statistic #330
+129
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofr
requested changes
Jun 20, 2025
| @@ -61,6 +62,8 @@ pytz = ">=2020.5" | |||
|
|
|||
| [tool.poetry.group.dev.dependencies] | |||
| setuptools = "^71.1.0" | |||
| testcontainers = "^4.10.0" | |||
| redis = "^6.2.0" | |||
There was a problem hiding this comment.
Already specified in non-dev deps
| from .throttling import throttling | ||
| from .urls import register_url_regexp | ||
|
|
||
|
|
||
| def setup(): | ||
| def setup(redis_throttling_configuration: RedisThrottlingConfiguration): |
There was a problem hiding this comment.
I think we need to extract this to a separate function to make it optional.
|
|
||
| def allow_request(self, request: django.http.HttpRequest) -> bool: | ||
| ident = _get_ident(request) | ||
| key = _get_cache_key(self._throttling.scope, ident) | ||
|
|
||
| history = default_cache.get(key, []) | ||
| now = time.time() | ||
| with self._storage.lock(key, timeout_sec=2): |
There was a problem hiding this comment.
I think it's better to avoid locks and rely on Redis atomic operations, something like:
pipe = redis.pipeline()
pipe.zadd(key, {str(now): now})
pipe.zremrangebyscore(key, 0, now - self._throttling.duration)
pipe.zcard(key)
pipe.expire(key, self._throttling.duration)
_, _, count, _ = pipe.execute()
return count <= limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.