WI00856225 - Remove FluentAssertions from Blazor.Diagrams.Core.Tests#49
Conversation
tests/Blazor.Diagrams.Core.Tests/Behaviors/DragNewLinkBehaviorTests.cs
Outdated
Show resolved
Hide resolved
| Assert.Equal(203.4,pt.X); | ||
| Assert.Equal(361.8, pt.Y); |
There was a problem hiding this comment.
| Assert.Equal(203.4,pt.X); | |
| Assert.Equal(361.8, pt.Y); | |
| Assert.Equal(203.4,pt.X); // 2*X + panX + left | |
| Assert.Equal(361.8, pt.Y); // 2*Y + panY + top |
Let's keep this comment. It may be useful when debugging.
tests/Blazor.Diagrams.Core.Tests/Models/Base/BaseLinkModelTests.cs
Outdated
Show resolved
Hide resolved
| Assert.Equal(10, node.Position.X); | ||
| Assert.Equal(0, node.Position.Y); | ||
| Assert.Equal(90, node.Size.Width); | ||
| Assert.Equal(215, node.Size.Height); |
There was a problem hiding this comment.
| Assert.Equal(10, node.Position.X); | |
| Assert.Equal(0, node.Position.Y); | |
| Assert.Equal(90, node.Size.Width); | |
| Assert.Equal(215, node.Size.Height); | |
| Assert.Equal(10, node.Position.X); | |
| Assert.Equal(0, node.Position.Y); | |
| Assert.Equal(90, node.Size.Width); | |
| Assert.Equal(215, node.Size.Height); |
tests/Blazor.Diagrams.Core.Tests/Behaviors/DragNewLinkBehaviorTests.cs
Outdated
Show resolved
Hide resolved
tests/Blazor.Diagrams.Core.Tests/Behaviors/KeyboardShortcutsDefaultsTests.cs
Outdated
Show resolved
Hide resolved
tests/Blazor.Diagrams.Core.Tests/Behaviors/KeyboardShortcutsDefaultsTests.cs
Outdated
Show resolved
Hide resolved
Removal of FluentAssertions from Blazor.Diagrams.Tests.csproj and [Directory.Packages.props] is part of my 2nd work item |
Alvarenga1
left a comment
There was a problem hiding this comment.
Let's fix the formatting and address all GitHub actions warnings.
| <ItemGroup> | ||
| <PackageReference Include="SvgPathProperties" /> | ||
| <ItemGroup> | ||
| <PackageReference Include="SvgPathProperties" /> |
There was a problem hiding this comment.
This is very minor, but could we fix the spacing here ?
| <Reference Include="SvgPathProperties" PrivateAssets="All"> | ||
| <HintPath>..\..\packages\svgpathproperties\1.1.2\lib\netstandard2.0\SvgPathProperties.dll</HintPath> | ||
| </Reference> | ||
| <PackageReference Include="SvgPathProperties" PrivateAssets="All" /> |
There was a problem hiding this comment.
spaces and warnings removed and checks passed
WI0085622-FluentAssertions needs to be removed from the project Blazor.Diagrams.Core.Tests