Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overrides with additional attributes aren't entirely pointless. #148

Merged
merged 4 commits into from
May 20, 2021
Merged

Overrides with additional attributes aren't entirely pointless. #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ff5497
Add test for subclass adding attributes
yaakov-h May 20, 2021
3d71655
Add tests for property and event
yaakov-h May 20, 2021
616af02
add Indexer test
yaakov-h May 20, 2021
0d837fb
Overrides that declare attributes should not be considered pointless.
yaakov-h May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions WTG.Analyzers.Test/TestData/PointlessOverrideAnalyzer/Attributes/Source.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
using System;
using System.ComponentModel;

namespace Magic
{
class DerivedClass : BaseClass
{
[Obsolete("Please don't use this anymore")]
public override void Method(int argument1) => base.Method(argument1);

[EditorBrowsable(EditorBrowsableState.Never)]
public override object Property
{
get => base.Property;
set => base.Property = value;
}

[EditorBrowsable(EditorBrowsableState.Advanced)]
public override event EventHandler Event
{
add => base.Event += value;
remove => base.Event -= value;
}

[Obsolete("Please don't use this anymore")]
public override object this[int index]
{
get => base[index];
set => base[index] = value;
}
}

class BaseClass
{
public virtual void Method(int argument1)
{
}

public virtual object Property { get; set; }

public virtual event EventHandler Event
{
add { }
remove { }
}

public virtual object this[int index]
{
get => null;
set { }
}
}
}
20 changes: 20 additions & 0 deletions WTG.Analyzers/Analyzers/PointlessOverride/PointlessOverrideAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ sealed class IsMeaningfulVisitor : CSharpSyntaxVisitor<bool>

public override bool VisitMethodDeclaration(MethodDeclarationSyntax node)
{
if (node.AttributeLists.Any())
{
return true;
}

var expression = node.Accept(SolitaryExpressionLocator.Instance);

if (expression == null || !expression.IsKind(SyntaxKind.InvocationExpression))
Expand All @@ -117,6 +122,11 @@ public override bool VisitMethodDeclaration(MethodDeclarationSyntax node)

public override bool VisitPropertyDeclaration(PropertyDeclarationSyntax node)
{
if (node.AttributeLists.Any())
{
return true;
}

if (node.ExpressionBody != null)
{
return !IsMatchingSelf(node.ExpressionBody.Accept(SolitaryExpressionLocator.Instance));
Expand Down Expand Up @@ -175,6 +185,11 @@ bool IsMatchingSelf(ExpressionSyntax? expression)

public override bool VisitIndexerDeclaration(IndexerDeclarationSyntax node)
{
if (node.AttributeLists.Any())
{
return true;
}

if (node.ExpressionBody != null)
{
return !IsMatchingSelf(node.ExpressionBody.Accept(SolitaryExpressionLocator.Instance));
Expand Down Expand Up @@ -234,6 +249,11 @@ bool IsMatchingSelf(ExpressionSyntax? expression)

public override bool VisitEventDeclaration(EventDeclarationSyntax node)
{
if (node.AttributeLists.Any())
{
return true;
}

foreach (var accessor in node.AccessorList.Accessors)
{
switch (accessor.Kind())
Expand Down