Conversation
AaronBederWTG
requested review from
brian-reichle and
yaakov-h
as code owners
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.0.1" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="8.0.0"> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.14.0" /> |
There was a problem hiding this comment.
These raise the minimum version of Roslyn that the Analyzer can run in, which effectively raises the minimum Visual Studio and .NET SDK versions that we run in. This is not something to be done lightly.
There was a problem hiding this comment.
This comment should actually go on the production project and not the test project, but the point is the same.
There was a problem hiding this comment.
Sorry, Janitor running locally created Janitor PRs via the oauth token 😱 . Will add developer config to Janitor to test modernize without PR creation.
There was a problem hiding this comment.
Without saying too much (this is a public repo after all), you can probably expand upon --dry-run to be a bit more useful here. Right now it is very cautious.
2 participants
No description provided.