-
-
Notifications
You must be signed in to change notification settings - Fork 1
fix(deps): update dependency stylelint to v17 #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @WomB0ComB0, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR updates stylelint to a new major version (v17). This is a significant update with several breaking changes as noted in the release notes. While updating dependencies is good practice, this major version bump requires careful consideration. Specifically, stylelint-config-standard-scss might not be compatible with stylelint v17, which could break your linting setup. Please see my comment on package.json. Also, be aware that stylelint v17 requires Node.js >= 20.19.0 and changes the default behavior of the --fix flag. It's recommended to run the lint script locally to ensure everything works as expected after this update.
| "stylelint": "^17.0.0", | ||
| "stylelint-config-standard-scss": "^16.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating stylelint to v17 is a major change that likely introduces breaking changes for its ecosystem. The stylelint-config-standard-scss package is likely not compatible with stylelint v17.
Most stylelint plugins and shared configs declare stylelint as a peer dependency with a specific version range. A major version bump of stylelint usually requires corresponding major version bumps of its plugins and configs.
Installing stylelint@17 without updating stylelint-config-standard-scss will likely cause peer dependency conflicts and may break your linting command.
Recommendation:
Please verify that stylelint-config-standard-scss has a version compatible with stylelint@17 and update it in this PR as well. If a compatible version is not yet available, it would be best to postpone this stylelint update to avoid breaking the linting process.
This PR contains the following updates:
^16.26.1→^17.0.0Release Notes
stylelint/stylelint (stylelint)
v17.0.0Compare Source
It contains 14 breaking changes, which we've detailed in the migrating to
17.0.0guide. Additionally, it adds 3 options to the rules and fixes 9 bugs. We've also released compatible versions of our shared config, Visual Studio Code extension, Node.js Rule Tester and Jest preset.outputproperty in the Node.js API returned resolved object (#8878) (@jeddy3).resolveNestedSelectorsoption fromselector-class-pattern(#8931) (@jeddy3).checkContextFunctionalPseudoClassesoption fromselector-max-id(#8913) (@jeddy3).fixmode tostrict(#8889) (@jeddy3).reportto be consistent and predictable in how it handles the provided position arguments (#8217) (@romainmenke).selector-max-*syntax rules for standard CSS nesting and modern functional pseudo-classes (#8913) (@jeddy3).*-specificitysemantic rules for standard CSS nesting (#8913) (@jeddy3).no-duplicate-selectorsandselector-no-qualifying-typefor standard CSS nesting (#8913) (@jeddy3).*-listrules to have consistent behaviour for vendor prefixes and case (#8912) (@jeddy3).*-no-vendor-prefixrules to have consistent behaviour for theirignore*: []secondary options (#8924) (@jeddy3).declaration-property-max-valuesrule to have consistent behaviour for vendor prefixes (#8926) (@jeddy3).except: ["after-block"]tocustom-property-empty-line-before(#8921) (@kovsu).except: ["after-block"]todeclaration-empty-line-before(#8910) (@kovsu).ignoreSelectors: []tono-duplicate-selectors(#8883) (@kovsu).at-rule-descriptor-no-unknownfalse positives for declarations within feature-value-blocks (#8868) (@kovsu).declaration-block-no-redundant-longhand-propertiesfalse negatives for short and long combinations (#8892) (@nathannewyen).media-feature-name-no-unknownfalse positives for namespaced dollar variables and range context queries (#8890) (@kovsu).nesting-selector-no-missing-scoping-rootfalse positives for CSS-in-JS (#8905) (@kovsu).no-invalid-position-declarationfalse negatives for embedded blocks (#8907) (@kovsu).selector-no-qualifying-typefalse negatives for:is/where()(#8940) (@romainmenke).selector-type-no-unknownfalse positives for MathML 4 tags (#8874) (@jeddy3).Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.