-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TT1 blocks: cleanup CSS #28
Conversation
--------------------------------------------------------------*/ | ||
|
||
.wp-block-cover.is-style-twentytwentyone-border { | ||
.is-style-twentytwentyone-border { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed so we don't lose the border on already inserted patterns with the old markup. I hope by the end of this PR we can move this to style.css
} | ||
|
||
/* | ||
* Alignment styles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will add the theme.json for the global padding on this issue
Should we merge this and the theme.json update to one branch (I don't know how but I think it would be easier) |
I don't, either. We could make one PR based on the other but I don't know how much we need to do that, this PR so far is not touching on theme.json, I was expecting the theme.json PR to be merged before this one anyway |
I'm finding it difficult to see how the theme.json changes affect the theme because that PR doesn't remove the CSS. |
I'm not working on this today, if you want you can cherry pick my commits to your PR and we can close this one |
Merged these changes inside #29 so we just work on that one branch. Closing this. |
Closes #24
This PR is a WIP. We are aiming to remove most of (if not all) the CSS from the theme.