Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wp-admin menu for git repository configuration #438

Closed
wants to merge 3 commits into from

Conversation

madhusudhand
Copy link
Member

This adds Admin menu for git repository configuration.

It enables to add settings such as Repository URL, Access Token etc.. and Disconnect repository.
It saves the set configuration using 'update_option'.

Note: This just saves and deletes the settings. Does not clone the actual repository.

image image

@pbking
Copy link
Contributor

pbking commented Aug 10, 2023

Considering how in previous incarnations of this work, from the site editor there was the option to connect individual themes to a repository. This (from a UX perspective at least) seems to connect the entire SITE to a single repository.

If we're going to keep the repository settings per-theme then I believe there should be two options for this:

  • Connect THIS theme to a repository
  • Install a theme from a repository

Does that line up with your thinking?

@madhusudhand
Copy link
Member Author

@pbking I created this as small chunk to speedup the review process and bring the changes in :)
But I agree, having both options (connecting with all themes, and active theme) should give the overall picture for review.

Pushed next set of changes in this PR and following are few screenshots.

image image image

@pbking
Copy link
Contributor

pbking commented Apr 29, 2024

We no longer have plans for CBT to manage a theme via git so closing this as an "interesting experiment".

@pbking pbking closed this Apr 29, 2024
@vcanales vcanales deleted the git/add-admin-menu branch May 23, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants