Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npx for commit linting scripts #467

Conversation

creativecoder
Copy link
Contributor

@creativecoder creativecoder commented Nov 3, 2023

This update the package.json config for pre-commit hooks to use npx.

This prevents errors when committing if you don't have wp-scripts installed globally, and makes sure to use the version specified by package.json.

Testing instructions

Make a commit locally on this branch and make sure pre-commit hooks run as expected.

Since this PR is from a fork, you may want to use github-cli to test, e.g. gh pr checkout 467 (https://cli.github.com/manual/gh_pr_checkout)

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@vcanales vcanales merged commit d30fcae into WordPress:trunk Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants