Removed all of the code relating to 'folder management' of a theme. #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
LGTM!
I was worried about backward compatibility issues, i.e. what would happen if I had already moved themes into a subfolder, but when I switch to this branch, themes that have been moved into a subfolder continue to work properly.
Since there is a conflict, it may be a good idea to retest after resolving the conflict just to be safe.
vcanales
force-pushed
the
fix/remove-subfolder-management
branch
from
4ef60f0
to
0c7be00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes reference to it from the Metadata modal.
Does not leverage it when cloning a theme or creating a new theme.
Themes in folders continue to export as expected. Themes cloned from themes in folders are cloned as expected, but the
/themesfolder is now targeted as the new theme's destination rather than whatever folder the origin theme was in.Fixes #716
Fixes #500