-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Navigator
: add basic history support, enable advanced focus restoration
#37223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d700ffe
`Navigator`: add basic history support
ciampo 96f1d5f
Update Navigator usage across the repo
ciampo 533e61f
Typo
ciampo 092acf5
Rename `navigationTriggerElement` to `focusRestorationSelector`
ciampo 7f8339f
Add focus restoration on navigating back
ciampo 7b86743
Update Navigator stories to work with focus restoration
ciampo 1a773b9
Add focus restoration support to Preferences Modal and GLobal Styles …
ciampo c78e792
Add `isInitial` property to the `location` object, use it instead of …
ciampo af8a6dd
Wrap `push` and `pop` in `useCallback`
ciampo 94eb58c
Rename `focusRestorationSelector` to `focusTargetSelector`
ciampo 3af4385
Make sure that `isInitial` and `isBack` cannot be overridden when pus…
ciampo ba08a42
Add `NavigatorLink` and `NavigatorBackLink`, replace usages across co…
ciampo 76e88c6
Use `id` as the attribute to restore focus
ciampo 8915a7c
Add `NavigatorLink` and `NavigatorBackLink` to docs manifest
ciampo 38c4ed2
Refactor to hooks
ciampo df584de
Do not expose `selectorFactor` prop
ciampo d219320
Use `Button` as detault component to render `NavigatorLink` and `Navi…
ciampo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
export { default as NavigatorProvider } from './navigator-provider'; | ||
export { default as NavigatorScreen } from './navigator-screen'; | ||
export { default as NavigatorLink } from './navigator-link'; | ||
export { default as NavigatorBackLink } from './navigator-back-link'; | ||
export { default as useNavigator } from './use-navigator'; |
19 changes: 19 additions & 0 deletions
19
packages/components/src/navigator/navigator-back-link/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# `NavigatorBackLink` | ||
|
||
<div class="callout callout-alert"> | ||
This feature is still experimental. “Experimental” means this is an early implementation subject to drastic and breaking changes. | ||
</div> | ||
|
||
**TODO** | ||
|
||
The `Navigator*` family of components is _not_ opinionated in terms of UI, and can be composed with any UI components to navigate between the nested screens. | ||
|
||
## Usage | ||
|
||
**TODO** | ||
|
||
## Props | ||
|
||
The component accepts the following props: | ||
|
||
**TODO** |
32 changes: 32 additions & 0 deletions
32
packages/components/src/navigator/navigator-back-link/component.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
// eslint-disable-next-line no-restricted-imports | ||
import type { Ref } from 'react'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import { contextConnect, WordPressComponentProps } from '../../ui/context'; | ||
import { View } from '../../view'; | ||
import { useNavigatorBackLink } from './hook'; | ||
import type { NavigatorBackLinkProps } from '../types'; | ||
|
||
function NavigatorBackLink( | ||
props: WordPressComponentProps< NavigatorBackLinkProps, 'button' >, | ||
forwardedRef: Ref< any > | ||
) { | ||
const navigatorBackLinkProps = useNavigatorBackLink( props ); | ||
|
||
return <View ref={ forwardedRef } { ...navigatorBackLinkProps } />; | ||
} | ||
|
||
/** | ||
* TODO: add example | ||
*/ | ||
const ConnectedNavigatorBackLink = contextConnect( | ||
NavigatorBackLink, | ||
'NavigatorBackLink' | ||
); | ||
|
||
export default ConnectedNavigatorBackLink; |
37 changes: 37 additions & 0 deletions
37
packages/components/src/navigator/navigator-back-link/hook.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { useCallback } from '@wordpress/element'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import { useContextSystem, WordPressComponentProps } from '../../ui/context'; | ||
import Button from '../../button'; | ||
import useNavigator from '../use-navigator'; | ||
import type { NavigatorBackLinkProps } from '../types'; | ||
|
||
export function useNavigatorBackLink( | ||
props: WordPressComponentProps< NavigatorBackLinkProps, 'button' > | ||
) { | ||
const { onClick, as = Button, ...otherProps } = useContextSystem( | ||
props, | ||
'NavigatorBackLink' | ||
); | ||
|
||
const { pop } = useNavigator(); | ||
const handleClick: React.MouseEventHandler< HTMLElement > = useCallback( | ||
( e ) => { | ||
e.preventDefault(); | ||
pop(); | ||
onClick?.( e ); | ||
}, | ||
[ pop, onClick ] | ||
); | ||
|
||
return { | ||
as, | ||
onClick: handleClick, | ||
...otherProps, | ||
}; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { default } from './component'; |
19 changes: 19 additions & 0 deletions
19
packages/components/src/navigator/navigator-link/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# `NavigatorLink` | ||
|
||
<div class="callout callout-alert"> | ||
This feature is still experimental. “Experimental” means this is an early implementation subject to drastic and breaking changes. | ||
</div> | ||
|
||
**TODO** | ||
|
||
The `Navigator*` family of components is _not_ opinionated in terms of UI, and can be composed with any UI components to navigate between the nested screens. | ||
|
||
## Usage | ||
|
||
**TODO** | ||
|
||
## Props | ||
|
||
The component accepts the following props: | ||
|
||
**TODO** |
29 changes: 29 additions & 0 deletions
29
packages/components/src/navigator/navigator-link/component.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
// eslint-disable-next-line no-restricted-imports | ||
import type { Ref } from 'react'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import { contextConnect, WordPressComponentProps } from '../../ui/context'; | ||
import { View } from '../../view'; | ||
import { useNavigatorLink } from './hook'; | ||
import type { NavigatorLinkProps } from '../types'; | ||
|
||
function NavigatorLink( | ||
props: WordPressComponentProps< NavigatorLinkProps, 'button' >, | ||
forwardedRef: Ref< any > | ||
) { | ||
const navigatorLinkProps = useNavigatorLink( props ); | ||
|
||
return <View ref={ forwardedRef } { ...navigatorLinkProps } />; | ||
} | ||
|
||
/** | ||
* TODO: add example | ||
*/ | ||
const ConnectedNavigatorLink = contextConnect( NavigatorLink, 'NavigatorLink' ); | ||
|
||
export default ConnectedNavigatorLink; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { useCallback } from '@wordpress/element'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import { useContextSystem, WordPressComponentProps } from '../../ui/context'; | ||
import Button from '../../button'; | ||
import useNavigator from '../use-navigator'; | ||
import type { NavigatorLinkProps } from '../types'; | ||
|
||
const cssSelectorForAttribute = ( attrName: string, attrValue: string ) => | ||
`[${ attrName }="${ attrValue }"]`; | ||
|
||
export function useNavigatorLink( | ||
props: WordPressComponentProps< NavigatorLinkProps, 'button' > | ||
) { | ||
const { | ||
path, | ||
onClick, | ||
as = Button, | ||
attributeName = 'id', | ||
...otherProps | ||
} = useContextSystem( props, 'NavigatorLink' ); | ||
|
||
const { push } = useNavigator(); | ||
const handleClick: React.MouseEventHandler< HTMLElement > = useCallback( | ||
( e ) => { | ||
e.preventDefault(); | ||
push( path, { | ||
focusTargetSelector: cssSelectorForAttribute( | ||
attributeName, | ||
path | ||
), | ||
} ); | ||
onClick?.( e ); | ||
}, | ||
[ push, onClick ] | ||
); | ||
|
||
return { | ||
as, | ||
onClick: handleClick, | ||
path, | ||
...otherProps, | ||
[ attributeName ]: path, | ||
}; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { default } from './component'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.