Update negative values for margins #40653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
talldan
reviewed
Apr 28, 2022
| @@ -57,7 +57,7 @@ export default function BoxControl( { | |||
| resetValues = DEFAULT_VALUES, | |||
| allowNegativeValues = false, | |||
| } ) { | |||
| inputProps = allowNegativeValues ? { min: -Infinity } : defaultInputProps; | |||
| inputProps.min = allowNegativeValues ? -Infinity : defaultInputProps.min; | |||
There was a problem hiding this comment.
Thanks for following up, Justin!
I'm actually wondering about this new prop. If a dev does something like this:
<BoxControl
inputProps={ { min: -10 } }
allowNegativeValues
/>At first glance this looks correct, but the minimum of -10 is actually being overwritten still with -Infinity by this code.
There are probably ways to fix that, but then another scenario is something meaningless like:
<BoxControl
inputProps={ { min: 5 } }
allowNegativeValues
/>I think it might be best not to have two props that can do the same thing. Maybe there's no need for the allowNegativeValues prop at all, and the BoxControl used for margin could be simplified to:
<BoxControl
inputProps={ { min: -Infinity } }
/>It isn't as clean as allowNegativeValues, but I think it's less likely to cause confusion.
|
Closing this in favor of #40674. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follows up #40464.
Why?
The initial PR had an issue where the
inputPropscould be unusable. See #40464 (comment).How?
This PR set back
inputPropstodefaultInputPropsin theBoxControl()function, and updates its value toinputProps.min = allowNegativeValues ? -Infinity : defaultInputProps.min;.Testing Instructions