Block Social Links: Make links use CSS variables instead of just hex code. #42284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for color with hex fallback. Allows site colors to be changed and update the social link icons as well instead of staying set at what they were originally set at.
|
Size Change: +47 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
BE-Webdesign
added
[Feature] Full Site Editing
[Type] Enhancement
|
It would be nice to see this enhancement in WordPress 6.1 @ajitbohra |
skorasaurus
added
the
[Block] Social
annezazu
added
[Feature] Site Editor
Contributor
|
Sorry for being late in paying attention to this PR. This issue appears to have been resolved by #51020. Therefore, I would like to close this PR, but thank you for your efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36462.
What?
Make social links use CSS variable for color with hex fallback. Allows site colors to be changed and update the social link icons as well instead of staying set at what they were originally set at.
Why?
Allows full site editing to change colors without needing to individually change every instance of the social links block to update to the new color.
How?
Adds two variables, iconColor and iconBackgroundColor, to the context passed down to social link items. The color slug is then used to populate the CSS variable with the hex code as a fall back in case a theme switch were to happen.
Testing Instructions
Screenshots or screencast