Skip to content

Pullquote Block: Add padding and margin support #45731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 7 commits into from
Jan 16, 2024
Merged

Pullquote Block: Add padding and margin support #45731

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b5cea30
Pullquote Block: Add padding and margin support
t-hamano Nov 12, 2022
e828e42
Update padding styles
t-hamano Nov 17, 2022
0604724
Merge branch 'trunk' into add/padding-margin-support-to-pullquote
t-hamano Nov 17, 2022
3215f75
Merge branch 'trunk' into add/padding-margin-support-to-pullquote
t-hamano Dec 10, 2022
4b2e935
Merge branch 'trunk' into add/padding-margin-support-to-pullquote
t-hamano Dec 30, 2023
1f7c980
Merge branch 'trunk' into add/padding-margin-support-to-pullquote
t-hamano Jan 13, 2024
dc689c4
Don't use __experimentalStyle
t-hamano Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference-guides/core-blocks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ Give special visual emphasis to a quote from your text. ([Source](https://github

- **Name:** core/pullquote
- **Category:** text
- **Supports:** align (full, left, right, wide), anchor, color (background, gradients, link, text), typography (fontSize, lineHeight)
- **Supports:** align (full, left, right, wide), anchor, color (background, gradients, link, text), spacing (margin, padding), typography (fontSize, lineHeight)
- **Attributes:** citation, textAlign, value

## Query Loop
Expand Down
4 changes: 4 additions & 0 deletions packages/block-library/src/pullquote/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@
"text": true
}
},
"spacing": {
"margin": true,
"padding": true
},
"typography": {
"fontSize": true,
"lineHeight": true,
Expand Down
4 changes: 4 additions & 0 deletions packages/block-library/src/pullquote/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
color: inherit;
}

blockquote {
margin: 0;
}

&.alignleft,
&.alignright {
max-width: $content-width * 0.5;
Expand Down