Tag Processor: Merge independent tests into single file

[dmsnell]

What?

Replaces #44593

Merges the PHP unit test files for the Tag Processor into a single file. In #44593 things got tricky in the merge and this patch is a recreation of the same intent.

The Tag Processor unit tests started as isolated and fast unit tests which led to following PHPUnit standards and an independence from WordPress itself. Once we adopted the WordPress standard we had to adjust the tests to fall out of line with the PHPUnit standards and we had to start integrating the tests with WordPress core to handle things like attribute escaping.

There should be no new or missing tests in this patch, but all tests which were formerly in separate files and places should now be in one file.

Why?

We made a mistake and at some point introduced four test files and now we need to bring that back to a single file, or at least get rid of the files we don't want.

How?

Merging files by comparing what's in one and not another.

Testing?

This patch changes test code. We should verify that we're not removing a test that isn't in the new single test file. We should also ensure that the tests pass. We should also ensure that no new tests are introduced during this merge.

[codesandbox]

  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

[adamziel]

Shouldn't we keep these @dmsnell ?

[adamziel]

@dmsnell I compared this to the updated branch I have locally and they're mostly the same, only you took a much shorter route to get there which I love. I only have one note – see above.

[dmsnell]

@adamziel I added those isolated tests in but then removed them because everything I tried to get the tests to run in CI failed. if someone can find a way to undefine WP_DEBUG then we can fix this.

I tried using the @runInSeparateProcess and @preserveGlobalState disabled special comments, tried using a different $GLOBALS['TEST_WP_DEBUG'], tried using $global $TEST_WP_DEBUG, and a few other things but every single one failed for a similar reason where the constant bled into the other tests.

the way we had it, which worked fine on our laptops, failed in CI because it was trying to serialize the exception, or the data providers, or both. by adding @preserveGlobalState disabled I got around that, but then the tests without WP_DEBUG defined were failing because WP_DEBUG was still defined from the other tests.

:sigh: