Fixed wp-env start On Windows
#50895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it's possible for the user creation to fail, it's possible that there will be no user by the given name to switch to. To prevent any errors we should switch to the UID:GID so that if the username was not created we don't error out.
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
noahtallen
added
the
[Type] Bug
noahtallen
approved these changes
May 23, 2023
Member
noahtallen
left a comment
noahtallen
left a comment
There was a problem hiding this comment.
The changes make sense to me; I'll let you and @t-hamano test it on Windows!
|
Flaky tests detected in f126963. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5062594083
|
Contributor
Author
|
Thanks @noahtallen, In the process of going through this pull request on Windows (natively) I managed to find a couple more issues with Windows that I resolved.
I've thoroughly tested these changes on both Windows and macOS to confirm that they don't break anything. It looks like Windows is working completely. @t-hamano I'm going to avoid merging this just yet, but, I'd like to get it in before tomorrow's automatic package release that way Windows will be functional again. |
t-hamano
approved these changes
May 24, 2023
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thank you for the quick response! Everything worked as expected.
I tested on a Windows host OS using the following commands:
git fetch origin fix/wp-env-windows-start
git checkout fix/wp-env-windows-start
npm run wp-env destroy
npm ci
npm run build
npm run wp-env start
- ✅ Started up with no problem
- ✅ Install and remove themes
- ✅ Install and remove plugins
- ✅ Uploading media
- ✅ Updating code using the theme editor
- ✅ Switching languages (i.e., downloading language files)
Contributor
Author
|
Thanks for the thorough review @t-hamano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This pull request assigns an arbitrary
uidandgidof1000when runningwp-envfrom Windows natively (without using WSL).Closes #50814.
Why?
When we fixed the permission-related problems we introduced an incompatibility when running
wp-envusing Windows natively. While it does work with WSL, when used natively, theuidandgidare-1. We handled this case by assigning it auidandgidof0, but, this introduced other problems with trying to run everything asroot.How?
We just assign an arbitrary
uidandgid. This should work fine because Windows is already performing magic for us with filesystem permissions to get everything in working order in the first place. It doesn't really matter to Windows what the user is because the Docker container has full permissions.Testing Instructions
nodeon Windows without using WSL. Meaning you should be able to run it from PowerShell or CMD.npx wp-env startfrom Windows without using WSL. It should boot correctly without any problems.