Social Link: Remove block on DELETE if empty url
#50903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
force-pushed
the
remove/empty-social-link-on-delete
branch
from
cf875bc to
d2fa814
Compare
ellatrix
reviewed
May 24, 2023
ellatrix
reviewed
May 24, 2023
|
Size Change: +116 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
May 24, 2023
ntsekouras
commented
May 24, 2023
| } | ||
| placeholder={ __( 'Enter address' ) } | ||
| disableSuggestions={ true } | ||
| onKeyDown={ ( event ) => { |
Contributor
Author
There was a problem hiding this comment.
This is mostly whitespace changes besides the onKeyDown and the useDispatch line.
ellatrix
reviewed
May 24, 2023
|
|
||
| A callback invoked on the keydown event. | ||
|
|
||
| - Required: No |
Member
There was a problem hiding this comment.
Can't we inherit all normal input props?
Contributor
Author
There was a problem hiding this comment.
I guess this could be a follow up. We can land this for now, no?
cbravobernal
changed the title
DELETE if empty urlDELETE if empty url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #49761
This PR removes a Social Link block if the
urlvalue is empty and we pressDELETE.Testing Instructions
DELETEand observe the block is not removed and works as expectedDELETEand observe the block is removed.