Remove unneeded block.json name-only imports #53677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
jsnajdr
commented
Aug 15, 2023
| const hasFootnotesBlockType = useSelect( | ||
| ( select ) => | ||
| !! select( blocksStore ).getBlockType( 'core/footnotes' ), | ||
| [] |
There was a problem hiding this comment.
Here the code cares only whether the block is registered or not. Return a boolean from useSelect should be slightly faster.
| ? [] | ||
| : [ createBlock( listName, listAttributes, children ) ] | ||
| ); | ||
| } |
There was a problem hiding this comment.
This createListItem function is unused. Nobody ever imports it from the utils.js module, and it's not a part of public API either.
| parentCount: getBlockParentsByBlockName( | ||
| clientId, | ||
| 'core/navigation-submenu' | ||
| ).length, |
There was a problem hiding this comment.
Little refactoring in order to call the getBlockParentsByBlockName just once.
| const blockName = `${ queryLoopName }/${ activeVariationName }`; | ||
| const activeVariationPatterns = useSelect( | ||
| const blockName = `core/query/${ activeVariationName }`; | ||
| const hasActiveVariationPatterns = useSelect( |
There was a problem hiding this comment.
Here again the code is interested only in the boolean value (is the list non-empty) not in the actual list.
|
Size Change: -455 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8aa9b90. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5866602572
|
gziolo
approved these changes
Aug 16, 2023
|
Nice one 👍 |
shimotmk
added a commit
to vektor-inc/vk-blocks-pro
that referenced
this pull request
Aug 29, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental step towards adopting standard JSON module imports, see also #34176 and #53470. This PR removes imports from
block.jsonfiles that only care about the block name (e.g.,core/heading).The code reads better (less indirection, better greppable) when the block names are hardcoded as strings. You will notice that virtually every modified file already references other block names as strings anyway.
Also, the JSON modules standard doesn't support named imports, only default ones. So, named import usages would need to be modified anyway, and here we solve the problem by removing them.
Because JSON imports are currently inlined by a Babel plugin, the
block-librarywill get a bit smaller, now that fullblock.jsonfiles are no longer inlined just to read the.namefield.The only remaining places that import
block.jsonfiles are the block registration scripts.