Changed the message when there are no pages from an error message to …

[mklute101]

Resolves #44486

@ndiego Another first contribution 👍

What?

When a page list block is empty, rather than returning an error message, simply state that there are no pages.

Why?

The current error message is unintuitive.

How?

It changes the error message to text

Testing Instructions

1. Set all pages in the test env to draft
2. Edit the header or footer template part
3. Insert a page list block.
4. Review the message

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mklute101! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[jasmussen]

I'd call it "You have no pages." Also, please get a code check on this one.

As a small step forward, let's ship this. That said, I still don't know that we want to show anything at all here. But I'll share my arguments on #44486 and we can look at that as a followup. Thanks for the PR!

[getdave]

Thank you for your PR 🙇

I'd like to confirm if this changed markup is perceivable by users of assistive technology. The Notice component comes with a set of built in affordances that are very important.

I sense the root of this PR is about the wording - I'm happy with that. However, I would like to understand why we decided to change the components used. What is the justification?

Many thanks

[jasmussen]

There's a bit more conversation in #44486 that touches specifically on this, notably that I'm questioning the usability of showing notice content in the canvas at all. I will defer to experts in the field, but my intuition would be that the content canvas would not be where I'd look for error notices, were I a screen-reader user. To that end, and to ensure actual WYSIWYG, I really think we should move towards having the canvas for content, and the UI for notices and error messages.

[draganescu]

I don't see the new message :(

In the screenshot the nav block is there but invisible - while on trunk the error in page list shows.

[draganescu]

I tested and just using a simple span is better, no className and no data-rich-text-placeholder. Just a span with the text passed through __.

[jameskoster]

"You" infers site ownership upon the current user which may not be appropriate in enterprise environments with may users with different roles. Perhaps something like "No pages found" would work better?

[mklute101]

Would it make sense for the language to be the same as an empty post list/query loop? "No results found"

[draganescu]

@mklute101 it should be more specifc than "results" because this is a more specific block trying to fall back to a default and it can't - because there are no pages. So we need to talk about pages.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mklute101 <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: getdave <[email protected]>
Co-authored-by: draganescu <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: javierarce <[email protected]>
Co-authored-by: jordesign <[email protected]>
Co-authored-by: mrfoxtalbot <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Stale