Separate layout child controls so each has its own reset. #59488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tellthemachines
changed the title
tellthemachines
commented
Mar 1, 2024
| <HStack> | ||
| <InputControl | ||
| size={ '__unstable-large' } | ||
| <HStack style={ { gridColumn: '1 / -1' } }> |
There was a problem hiding this comment.
This is a bit dodgy but I couldn't get spacing={ 2 } to work with HStack. Cc @mirka is there a better way to do it? 😅
|
Size Change: +915 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
I was thinking we'd want to group the column and row inputs together. So something like: "Grid position" would be hidden by default. |
In that case I'll wait until #59483 is merged to rebase and finish it. |
|
I've merged this into #59488. They're pretty related and I'm struggling to wrap my head around testing both of them 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses issue noticed here: #59483 (review)
Separates each layout child control into its own
ToolsPanelItem, so that each can be reset independently.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast