Template parts in patterns page: add author field #60372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
requested review from
mcsf,
youknowriad,
jorgefilipecosta and
ntsekouras
oandregal
added
[Type] Enhancement
5 tasks
oandregal
added
the
[Feature] Site Editor
|
Size Change: +97 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
oandregal
force-pushed
the
add/author-field-filter-template-parts
branch
from
d504864
to
731f382
Compare
33 tasks
oandregal
force-pushed
the
add/author-field-filter-template-parts
branch
from
731f382
to
16b2a02
Compare
oandregal
commented
Apr 10, 2024
| { withIcon && imageUrl && ( | ||
| <div | ||
| className={ classnames( | ||
| 'page-templates-author-field__avatar', |
There was a problem hiding this comment.
This style rules are defined in packages/edit-site/src/components/page-templates-template-parts/style.scss and is bundled as part of edit site stylesheet. It's the same as the existing Preview field below (page-templates-preview-field, etc.).
oandregal
commented
Apr 10, 2024
| @@ -201,6 +209,39 @@ function Preview( { item, categoryId, viewType } ) { | |||
| ); | |||
| } | |||
|
|
|||
| function Author( { item, viewType } ) { | |||
There was a problem hiding this comment.
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related #59659 #60359
What?
This PR adds an Author field & filter to the template parts present in the Patterns page. This follows what they have in the "Manage all template parts" page.
Gravacao.do.ecra.2024-04-02.as.15.12.24.mov
Why?
This is a pre-requisite to removing the "Manage all template parts" page in #60359
How?
authorfield and filter.Testing Instructions
Visit the Patterns page and select the Templates Parts items in the sidebar. Use the Author filter.