Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resizing items to top and left with GridItemResizer #60986

Merged
merged 13 commits into from
May 10, 2024
Merged

Fix resizing items to top and left with GridItemResizer #60986

merged 13 commits into from
May 10, 2024

Commits on May 9, 2024

  1. Fix resizing items to top and left with GridItemResizer

    @tellthemachines
    tellthemachines committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c0d99f0 View commit details
    Browse the repository at this point in the history

  2. Add min and max heights and get parent directly.

    @tellthemachines
    tellthemachines committed May 9, 2024
    Configuration menu
    Copy the full SHA
    333eefc View commit details
    Browse the repository at this point in the history

  3. Fix bounding element logic

    @tellthemachines
    tellthemachines committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f434924 View commit details
    Browse the repository at this point in the history

  4. Fix resizing logic

    @tellthemachines
    tellthemachines committed May 9, 2024
    Configuration menu
    Copy the full SHA
    0a6f97b View commit details
    Browse the repository at this point in the history

  5. Resize only to side that's not an edge

    @tellthemachines
    tellthemachines committed May 9, 2024
    Configuration menu
    Copy the full SHA
    84f1cb7 View commit details
    Browse the repository at this point in the history

  6. Fix handles becoming sticky

    @tellthemachines
    tellthemachines committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7e4dbb8 View commit details
    Browse the repository at this point in the history

  7. Try popover ref

    @tellthemachines
    tellthemachines committed May 9, 2024
    Configuration menu
    Copy the full SHA
    19e8ae2 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Handle resizing up and left by combining block rect and box rect

    @noisysocks
    noisysocks committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6957c76 View commit details
    Browse the repository at this point in the history

  2. Refresh handles after resize

    @tellthemachines
    tellthemachines committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4bc0167 View commit details
    Browse the repository at this point in the history

  3. Update comment

    @tellthemachines
    tellthemachines committed May 10, 2024
    Configuration menu
    Copy the full SHA
    e026dde View commit details
    Browse the repository at this point in the history

  4. Avoid useEffect firing twice

    @noisysocks
    noisysocks committed May 10, 2024
    Configuration menu
    Copy the full SHA
    69368e4 View commit details
    Browse the repository at this point in the history

  5. Avoid blockElement and rootBlockElement ever being null, combine root… 

    …BlockElement and gridElement
    @noisysocks
    noisysocks committed May 10, 2024
    Configuration menu
    Copy the full SHA
    795d661 View commit details
    Browse the repository at this point in the history

  6. Remove event listener on resize stop.

    @tellthemachines
    tellthemachines committed May 10, 2024
    Configuration menu
    Copy the full SHA
    20315d6 View commit details
    Browse the repository at this point in the history