-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Grid interactivity: Allow blocks to be positioned in manual mode using drag and drop #61025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
539bb86
Try version of grid where manual mode means all blocks have a columnS…
noisysocks 37ff369
Fix some rebase breakage
tellthemachines b3e7d95
Clean up deleted files
tellthemachines eb732d1
Fix visualiser
tellthemachines 6b72367
fix booboos
tellthemachines 73b821a
Show appender on manual grid
tellthemachines 9dff09b
Fix row situation when converting from auto to manual
tellthemachines eef95b2
Set row attribute
tellthemachines ef056c1
markup reordering on drag and drop
tellthemachines ca959da
Reorder markup when using movers
tellthemachines 4ac5e9d
Jump through a few hoops
tellthemachines 881af91
Only show sidebar row/col start controls in manual mode.
tellthemachines 5f6e8d7
Fix string concatenation bugs
tellthemachines 249549b
Undo folder rename
tellthemachines 86f0c1c
Fix inserters for different grid types
tellthemachines fa2b066
Allow overlap
tellthemachines 28ab6b9
Update file path
tellthemachines 29e97e1
Fix undo weirdness
tellthemachines e2b2897
Fix col and row start on resize
tellthemachines b79494d
Put back isDistractionFree check
noisysocks 81623d5
Use ternary
noisysocks 2b2e16a
Try to escape indent hell
noisysocks 9621ddb
Fix things for non-experimental mode
tellthemachines 2062300
Fix block movers when experiment disabled
tellthemachines f1141af
Refactor useGetBlocksBeforeCurrentCell to useGetNumberOfBlocksBeforeC…
noisysocks 3455e3c
remove todo comment
tellthemachines 51de6e8
Tidy useGridLayoutSync
noisysocks f1f82b2
Fix class name typo
noisysocks c12b098
Fix toggle label
tellthemachines c80ce4d
Bring back range control when experiment is disabled
tellthemachines d982fdf
Fix min rows needed when items span multiple cells
tellthemachines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.