Update: Implement new author panel design. #61362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +123 B (+0.01%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
update/implement-the-new-author-panel-design
branch
from
41028fe
to
e8949aa
Compare
jorgefilipecosta
force-pushed
the
update/implement-the-new-author-panel-design
branch
from
e8949aa
to
9773a1b
Compare
|
@jorgefilipecosta where does that 'Copy to a new draft' link in your screenshot come from? 🤔 |
Hi @jameskoster, that link was not related to this PR or core the link is from a third-party plugin that I was testing when I captured the screenshot. Sorry for having it included in the screenshot and causing confusion. |
|
No problem, just checking I wasn't missing a core feature we needed to account for! |
ntsekouras
reviewed
May 20, 2024
| <PostPanelRow label={ __( 'Author' ) } ref={ setPopoverAnchor }> | ||
| <Dropdown | ||
| popoverProps={ popoverProps } | ||
| className="editor-post-author__panel-dropdown" |
There was a problem hiding this comment.
We're not using this className.
ntsekouras
reviewed
May 20, 2024
| className="editor-post-author__panel-toggle" | ||
| variant="tertiary" | ||
| aria-expanded={ isOpen } | ||
| // translators: %s: Current post link. |
There was a problem hiding this comment.
Wrong translators comment 😄
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: jameskoster <[email protected]>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new author panel design shown here: #59689 (comment)
Screenshots
Testing Instructions
Verified I could still change the author of a post and page.