Remove onActionPerformed & onActionStart from the ActionModal API

[oandregal]

Follow-up to https://github.com/WordPress/gutenberg/pull/60805/files#r1599815188

What?

Removes onActionPerformed and onActionStart from the ActionModal API.

Why?

Those are properties available at the action, so it's not necessary to pass them to the modal as well.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: mcsf <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[youknowriad]

Are these properties specific to modal actions or should they be moved to ActionBase

[oandregal]

I only see them in use by RenderModal https://github.com/WordPress/gutenberg/blob/trunk/packages/dataviews/src/item-actions.tsx#L119

[youknowriad]

Makes sense. Given the names I think they can be supported in any type of action but since it follows our current implementation, it's fine to keep like that for now.

[mcsf]

Thank you :)