Skip to content

Conversation

@hbhalodia
Copy link
Contributor

@hbhalodia hbhalodia commented May 16, 2024

What?

Why?

  • This is need to make consistent and polish the blocks.

How?

  • This PR change the label and help text by removing the link word.

Testing Instructions

  1. Open any post/page.
  2. Add the social icons block and add the icons.
  3. For single icon, on the settings bar you can see the label is now changed to text, instead of link text.

Testing Instructions for Keyboard

  • NIL

Screenshots or screencast

Before After
Screenshot 2024-05-16 at 4 20 44 PM Screenshot 2024-05-16 at 4 14 20 PM

@hbhalodia hbhalodia requested a review from ajitbohra as a code owner May 16, 2024 10:52
@github-actions
Copy link

github-actions bot commented May 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: akasunil <[email protected]>
Co-authored-by: richtabor <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra added [Type] Copy Issues or PRs that need copy editing assistance [Block] Social Affects the Social Block - used to display Social Media accounts labels May 16, 2024
Copy link
Member

@akasunil akasunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@richtabor richtabor enabled auto-merge (squash) July 1, 2024 12:24
@richtabor richtabor merged commit da23882 into WordPress:trunk Jul 1, 2024
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 1, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: akasunil <[email protected]>
Co-authored-by: richtabor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Social Affects the Social Block - used to display Social Media accounts [Type] Copy Issues or PRs that need copy editing assistance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants