Add home template details to inspector controls #61762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
commented
May 17, 2024
|
Size Change: +932 B (+0.05%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 839a3af. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9154477143
|
|
I get a strange error when I build this branch: Any ideas? |
This doesn't seem related to this PR.. Have you resolved the issue? Probably with |
ntsekouras
force-pushed
the
add/home-template-details-to-inspector
branch
from
39a1785
to
839a3af
Compare
youknowriad
reviewed
May 20, 2024
youknowriad
reviewed
May 20, 2024
packages/editor/src/components/site-settings-panel/blog-title-panel.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
May 20, 2024
youknowriad
reviewed
May 20, 2024
ntsekouras
commented
May 20, 2024
| } ); | ||
| }; | ||
| return ( | ||
| <PostPanelRow label={ __( 'Posts per page' ) } ref={ setPopoverAnchor }> |
There was a problem hiding this comment.
This text wraps in two lines and I'm not sure how we can address that properly, since all labels have a width:30%. Should we apply some truncate rules to editor-post-panel__row-label in general?
It seems like we might have more similar use cases in the future, and it seems like a problem that could be happening already in different languages. --cc @WordPress/gutenberg-design
youknowriad
approved these changes
May 20, 2024
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: jameskoster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #59689
Designs are from: #59689 (comment)
This PR adds the home template details to inspector controls, similar to the ones that exist in details sidebar.
Testing Instructions
Blog title, Posts per page and Discussionrows in inspector controls.Screenshots or screencast