Pages data view: Add Pending and Private views #62138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +211 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Question: can these be shown only if there are pages in those taxonomies? It becomes a bit much otherwise, and it seems like this could be a default behavior for any of these taxonomies, unless custom pinned. Separately, we should find a better icon for at least private, but probably also pending. As I suggested in the other PR, since these are page statuses, they should probably all share some DNA with the base "page" shape.
|
I'd like to push back on this a little. The icons are supposed to communicate the status, not the post type. The fact that they relate to pages should be contextually apparent. 'Combo icons' (e.g. Page + small lock) wouldn't scale very well—we'd eventually need dedicated icons for pending posts, pending pages, pending comments, pending _$post_type_s, and so on. Additionally it results in the icons visually blurring together and potentially failing the 'squint' test. In that sense, the draft/published icons may be the ones to revisit. I do agree the icons need adjustment so that they're consistent. But I think that can potentially be done in a follow-up or during beta. The important thing to decide at the moment is whether or not to include these views for 6.6. |
|
The problem is, those icons were designed for different contexts, and dilute them by also applying to posts, IMO. I'm not voicing the strongest opinion in the world here, but for me, calendar is related to the date, not scheduled posts or pages. I realize that's a semantic detail, but it nevertheless feels meaningful to me. |
|
I agree with that. The status icons can share some DNA for sure, I'm just not convinced it should be based in the page footprint. It could be something like small icons inside circles. Example from a very quick image search: 
My feeling is that we can adjust the icons during beta, maybe even tomorrow if we're quick. I don't think that should hold up adding this new feature though. |
|
@jasmussen how do you feel about merging this one, then addressing the icons in #62136? |
jasmussen
approved these changes
May 31, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: jasmussen <[email protected]>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: jasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #62021. I'm unsure why these weren't included in #59659. I figured we can discuss in a PR.
What?
Adds views for pending and private pages in the Pages data view.
Why?
There are views for each of the other statuses (published, drafts, scheduled, trashed). It seems reasonable to include these too, particularly as there are such views in the wp-admin pages table.
I think there's room to explore alternative icons in follow-ups during beta.
Testing Instructions