TimePicker: Fix time zone overflow #63209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Jul 8, 2024
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the fix 🚀
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
* TimePicker: Fix time zone overflow * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* TimePicker: Fix time zone overflow * Add changelog Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a style regression introduced in #60613 where the time zone in the
TimePickerwas overflowing a bit.This was especially noticeable in the "Date" block:
How?
Remove the
width: 100%style in the container element, by adding aexpanded={ false }prop toHStack.Testing Instructions
Compare the result in the Storybook for
TimePicker. Or, in the editor, the post publish popover or the "Date" block.Screenshots or screencast