Skip to content

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Jul 15, 2024

What?

Requires #63564 and #63569
Part of #58850

Deprecate the legacy, unstable version of the Composite component.

Why?

See #58850

How?

  • Added JSDocs and runtime warnings
  • Added unit tests

Testing Instructions

  • Since there are no usages left of the unstable component, there shouldn't be any runtime changes;
  • Make sure that changes in the JSDocs are reflected correctly in modern IDEs
  • Make sure that deprecation warnings are outputted as expected in the console

@ciampo ciampo force-pushed the feat/stabilize-composite/deprecate branch from 4d96244 to aee7a65 Compare September 5, 2024 13:14
@ciampo ciampo added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Sep 5, 2024
@ciampo ciampo requested a review from a team September 5, 2024 13:19
@ciampo ciampo marked this pull request as ready for review September 5, 2024 13:20
@ciampo ciampo requested a review from ajitbohra as a code owner September 5, 2024 13:20
@github-actions
Copy link

github-actions bot commented Sep 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ciampo <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ciampo ciampo force-pushed the feat/stabilize-composite/deprecate branch from 7023906 to db6ccb9 Compare September 5, 2024 13:28
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Still tests well in Storybook.

Besides this one, what do we need to be able to close #58850? Just a dev note?

@ciampo ciampo merged commit 2fe092e into trunk Sep 5, 2024
@ciampo ciampo deleted the feat/stabilize-composite/deprecate branch September 5, 2024 15:36
@github-actions github-actions bot added this to the Gutenberg 19.3 milestone Sep 5, 2024
@ciampo
Copy link
Contributor Author

ciampo commented Sep 5, 2024

Besides this one, what do we need to be able to close #58850? Just a dev note?

I closed #58850 and added a dev note to #63569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants