FIX: make whole details clickable

[renishsurani]

Why?

Fixes #64116

How?

.wp-block-details {
	box-sizing: border-box;
	position: relative;
}

.wp-block-details summary {
	cursor: pointer;

	&::after {
		content: "";
		position: absolute;
		top: 0;
		left: 0;
		height: 100%;
		width: 100%;
	}
}

Added after to make whole details block clickable.

Screenshots or screencast

Screen.Recording.2024-07-31.at.8.13.37.PM.mov

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: [email protected].

Co-authored-by: jhmonroe <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: renishsurani <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @renishsurani! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[jhmonroe]

Why?

Fixes #64116

How?

.wp-block-details {
	box-sizing: border-box;
	position: relative;
}

.wp-block-details summary {
	cursor: pointer;

	&::after {
		content: "";
		position: absolute;
		top: 0;
		left: 0;
		height: 100%;
		width: 100%;
	}
}

Added after to make whole details block clickable.

Screenshots or screencast

Screen.Recording.2024-07-31.at.8.13.37.PM.mov

Hi @renishsurani I'm not an expert on implementation in terms of the best practices for WP Core CSS (I'm a designer and light front-end developer), so I can't be very helpful on how this fits in the big picture.

But, at seeing your video, it looks like the clickable area is where I imagined, but since you didn't hover over the revealed text underneath, I am not sure if your technique causes the revealed paragraph below to also be clickable...?

You may want to test with a longer paragraph or two so everyone can see how it functions with more text.

That was @carolinan 's concern in #64116. Understandably so— since this would also affect instances where someone is not using a background color and that could be unusual for people to see a clickable body paragraph in the middle of an article for instance. (if someone is using this as a standard details expander in the body of long text.

I'd love to have more people weigh in on this who worked on the Details block originally and thought through all the use cases! :-)

PS: Thanks!

[carolinan]

Thank you for trying this @renishsurani.

The problem with this solution is that it only works if there are no interactive elements inside the details.
For example, if you have a link in the content, trying to click on that link only closes the details.
So this is only suitable when you know exactly what is in the details, such as specific client projects or your own site: and not for the default of the block.

[renishsurani]

Thank you for trying this @renishsurani.

The problem with this solution is that it only works if there are no interactive elements inside the details. For example, if you have a link in the content, trying to click on that link only closes the details. So this is only suitable when you know exactly what is in the details, such as specific client projects or your own site: and not for the default of the block.

Okay @carolinan, I understand your point. I will try and let you know if a solution is found.

[jhmonroe]

It's interesting to see and inspect how Mozilla handles their Details block and applying padding around Summary as well as separately to the bottom of the .extra div(inside the green box on this page):
https://developer.mozilla.org/en-US/docs/Web/CSS/--*