Remove editorMode from blockProps #65326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -19 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Sep 17, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
force-pushed
the
try/remove-editorMode-block-props
branch
from
75e7489
to
1463954
Compare
jeryj
force-pushed
the
try/remove-editorMode-block-props
branch
from
1463954
to
2904872
Compare
getdave
pushed a commit
that referenced
this pull request
Oct 1, 2024
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
This reverts commit f53ac60.
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
cbravobernal
added
[Type] Performance
|
I think this needs to be backported to 6.7 as #65963 depends on it. c.c. @andrewserong and @getdave if I'm misunderstanding something. 🙇 |
kevin940726
added
the
Backport to WP 6.7 Beta/RC
This comment was marked as resolved.
This comment was marked as resolved.
kevin940726
pushed a commit
that referenced
this pull request
Oct 11, 2024
getdave
added a commit
that referenced
this pull request
Oct 11, 2024
Co-authored-by: jeryj <[email protected]> Co-authored-by: getdave <[email protected]>
kevin940726
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Seeing if there's a performance improvement by removing editorMode from the blockProps that was added in #64573
Why?
Potential performance improvement/code quality.
How?
Remove from block props, add a check within event listener.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast