-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Moves size settings to inspector controls. #65729
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks for the PR! The In particular, it will cause strange wrapping in CJK languages. Japanese (ja) 繁體中文 (zh-TW) The approach I can think of is to use actual numbers or icons instead of text, or use the |
Thanks @t-hamano for the review. If the number of options can increase in future then I think I have updated the PR with |
@vipul0425 Thanks for the update! Discussion on this issue is still ongoing in #65647, and it also has been proposed to allow custom values. Let's move forward with this PR once the direction of the discussion is decided. Sorry for the confusion 🙇♂️ |
What?
Fixes: #65647
Why?
The Social Icons block has a 'size' setting that is placed in a toolbar dropdown menu labeled 'Size', but in other blocks it is there in inspector controls.
How?
This PR moves the size settings to inspector controls.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-09-30.at.1.21.49.PM.mov