Limit zoom out toggle to specific post types #65732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
changed the title
draganescu
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +31 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Sep 30, 2024
| @@ -75,6 +78,10 @@ function Header( { | |||
| }; | |||
| }, [] ); | |||
|
|
|||
| const canBeZoomedOut = [ 'post', 'page', 'wp_template' ].includes( | |||
There was a problem hiding this comment.
Another case for this issue #61622
How do we see that longer term?
There was a problem hiding this comment.
It should be a thing supported by the CPT. This inclusion list above is a "temporary" hack that also keeps out zoom out even for CPTs that are perfectly valid 🤷🏻
youknowriad
approved these changes
Sep 30, 2024
richtabor
approved these changes
Sep 30, 2024
Yes, it's mostly aimed as a band aid for the fact we do not have a path for these situations. If one triggered programmatically zoom out view in an unsupported CPT maybe they also know how to work with it. |
|
Hey all 👋 Would it not have made more sense to provide a specific disallow list with the ability to filter it? as someone who works with a lot of custom post types this is something I would want to be available for the large majority of them. |
|
@fabiankaegy you may be right actually. I opted for an allow list because this feature is quite incipient and it should be honed on some basic assumptions first and then open to other situations. Ideally, like Riad also mentioned, composability should be a support of the post type (see #61622 and #65732). Pherhaps the best next step is to open an issue to serve as an anchor for a follow up - definitely this is not a final shape. |
|
Yes, this should be something broadly available. I think we should also aim at it being the default for any post type that supports "content". |
getdave
pushed a commit
that referenced
this pull request
Oct 1, 2024
Co-authored-by: draganescu <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: ajlende <[email protected]>
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
Co-authored-by: draganescu <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: ajlende <[email protected]>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
This reverts commit 44b09af.
draganescu
added a commit
that referenced
this pull request
Oct 2, 2024
Co-authored-by: draganescu <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: richtabor <[email protected]> Co-authored-by: ajlende <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #61044
Why?
How?
Hardcodes the post types we want the mode to be available for and does not render the affordance to access it for the others.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
selective-zoom-out-control.mp4